Zugg Software :: View topic

Newbie Joined: 17 Oct 2008 Posts: 7 Location: WV

Hi all, I'm using ZMud - I used to have a nice script to color the names of enemies (in Achaea) when I see them, and I see that there is a recent post about a similar issue, but this is a little different.

I've already figured out how to do the actual coloring of the names, what *I* need, is a way to automatically load the enemies list into my variables (ie - house enemies, city enemies)

Here is the problem.

My trigger line looks like this:

Enemies of the Sentinels of Nature:
enemy1, enemy2, enemy3, (and so on)

Now, I can get #additem to work just fine, as long as the string I want to capture is on the SAME LINE as the trigger line, but as you can see, this string falls on the SECOND line. How do I capture THAT and use #additem to put it into my variable? (@hems in this case)

Here is the code I wrote to add/delete my personal enemies:

Sorcerer Joined: 13 Jan 2006 Posts: 715

This isn't actually that hard, except for the variable length of the enemies line... I'm too tired to write it right now, and besides others here are better at this sort of trigger ;)
If I remember right though, this can't be done with normal zScript, you've gotta use a regex trigger. But I may be mistaken, like I said, I'll let someone else field this unless it isn't done when I check in at a time when I'm more lucid.

Newbie Joined: 17 Oct 2008 Posts: 7 Location: WV

Yeah, I'm sure it's a 'simple thing' I'm missing, but after struggling with it for DAYS now... (and scouring the internet without finding a solution that works), I figured I would just ask. lol ;) I tend to be pretty stubborn and like to figure things out for myself, but daggonit, there are so many 'variables' here (not in the coding sense) that I just can't seem to iron it out. Thanks for replying. Hopefully someone will help out.

And I hope it CAN be done with 'normal zScript'... I don't know the first thing about regex and I hate it when I don't understand my code!

Sorcerer Joined: 13 Jan 2006 Posts: 715

Regex isn't hard, and only the pattern would need to be regex. I just don't have much experience with regex so I still have to look EVERYTHING up. ;)

Really this is right up Vij's alley, I'm surprised he hasn't jumped on it yet.

SubAdmin Joined: 18 Nov 2001 Posts: 5187

Hrm, I could swear I have written this script for someone else before.

Newbie Joined: 17 Oct 2008 Posts: 7 Location: WV

*clap* Yay! Thanks! =D

I wouldn't be a bit surprised if you had written it before... but I couldn't find it, so thanks very much! It looks like all I need to do is swap HEnemy with hems to fill my hems variable with the House enemies. I actually want to keep my enemy lists separate (I'm considering using different colors... though it would be messy because they do overlap somewhat, or possibly making a trigger to notify me as to what 'lists' they are in... ANYway).

Oh, you're not using #additem anywhere! Ah, that's why the %dups line is in there. So, this can't be done with #additem then? Or it's too messy to do that way? Because it *seems* like it would be easier, but then I couldn't get it to work, so maybe not, but I also just thought my problem was in finding a way to get the #additem to pick up that second line after the trigger. Now I'm gonna go look up all that #state and #set stuff to see what you're doing. lol Thanks again!

Sorcerer Joined: 13 Jan 2006 Posts: 715

Geeze, and he didn't even need regex. But I had forgotten about the %line, so I'd not have been able to do it like that. Thanks Vij

Fragen, here is an example of what you'd probably want to do for each enemy. It also illustrates why you need the combined Enemies variable.

SubAdmin Joined: 18 Nov 2001 Posts: 5187

The script I wrote was just for capturing the house enemies, and putting that into a conjuctive list. I didn't use #ADDITEM because it is would be quite processor intensive. The mud itself is already ensuring uniqueness and all that is required is properly formatting the data as a list. I did that using a low level trick in the %subchar.

You should create addittional triggers for your city enemies and personal enemies. Each should use a seperate variable, but combine into the conjuctive list. Ralgith is correct that reason to have a single full list is so that one trigger can be used to mark all kinds of enemies. I made some changes to his code that will improve performance slightly while increasing compatibility with CMud, should you decide to upgrade. I also put the different enemy flags right before the name instead of after.

Newbie Joined: 17 Oct 2008 Posts: 7 Location: WV

Thanks, that looks very nice! My one question about the way you're using the color/key is how that's going to look when an enemy's name isn't in a 'list'... well I guess I can just try it and take a walk into Mhaldor and find out. ;) bahah

Newbie Joined: 17 Oct 2008 Posts: 7 Location: WV

Sorcerer Joined: 13 Jan 2006 Posts: 715

Here is the output form for City Enemies, and your trigger cannot capture this.

As you can see, sometimes the commas fall at the start of the next line. Also the trigger does not end in a blank line, so a failed #IF (%line) won't work.
Would #IF (%word(%line,1) != "Total:") work? Anyways, just hoping you can fix it ;)

Sorcerer Joined: 13 Jan 2006 Posts: 715

Oh, and you have a typo in your script that I corrected before I complained it doesn't work ;)
HousEnemy instead of HouseEnemy in the second #COND
Also, on the first COND should the params be there?

Wanderer Joined: 15 Jul 2005 Posts: 96

SubAdmin Joined: 18 Nov 2001 Posts: 5187

For ralgith, corrected the typo you mentioned and adjusted the end condition.

Sorcerer Joined: 13 Jan 2006 Posts: 715

Ok, thanks for explaining it. I've never seen it done that way, thus I was unsure how it should be corrected. I wasn't sure if the commas would interfere or not, thats why I mentioned it, but I guess if I had thought it through then I would have realized that with the concat method it doesn't matter. Thanks Vij, I'll test it and report back on it.

Sorcerer Joined: 13 Jan 2006 Posts: 715

Ok, tested it and it reaches state 2 and then that state never fires.
So what I did to make that state fire is add a pattern
^*$
to it, so the receipt of a single line makes it fire.

Now however it reaches the final "manual" line, which does not fire. Even though it should with a proper #SET, which we have.

Of course, it still isn't working correctly because it doesn't fully populate the variable. It only populates the first 30 lines parsed by the looplines portion, plus one extra. Then skips to the final set state. I've included the partial cEnemy var here so you can compare it to my actual CityEnemies list I posted before.

My edited trigger for CityEnemies

Posted: Sat Oct 25, 2008 5:51 pm

Ten thousand times easier way to do this:

CONFIG SCREENWIDTH 0

#trig {Enemies of the City of %w:} {CityEnemies=""}
#cond {(*)} {#forall %subchar(%1,", ","|") {#additem CityEnemies %i}}

Job done. Tested this with my city enemies just now and it works like a charm.

If you want your wrapping to look how it did before, set the wrap column to 80 and the indent to 0.

Also makes stuff like accounting for long names and channel capping easier :)

Newbie Joined: 17 Oct 2008 Posts: 7 Location: WV

doesn't work.... but thanks for trying :)

Sorcerer Joined: 13 Jan 2006 Posts: 715

Fang, Fragen and I are having problems with your trigger. It is only catching a single name... and it is a name that doesn't even appear on our screens let alone on the list. I'm looking into it more, but I don't understand why it should be doing so. And sometimes it throws an AV with it. That might be because of Vista though, I do get the occasional random AV that can't be blamed anywhere else.

Posted: Mon Oct 27, 2008 10:18 am

Well, that's weird, because I logged into Achaea and tested it myself in the game and it's working absolutely fine. Check the value of %1 and see if it's capturing properly.

Sorcerer Joined: 13 Jan 2006 Posts: 715

It was capturing it fine, but when it got subchar'ed it went all loopy.
I'm going to delete the entire thing and recreate it again, maybe I've got a typo in there somewhere or something.

Thanks again.

Posted: Mon Oct 27, 2008 2:52 pm

You could try using %replace to the same effect in that case.

SubAdmin Joined: 18 Nov 2001 Posts: 5187

#forall %subchar(%1,", ","|") {#additem CityEnemies %i}
simpler again
CityEnemies=%subchar("%1",", ","|")

There is no reason to keep people that are no longer enemies in this list, so we can just replace the entire list. Also this is zMud, where a %nn value containing things such as a comma can cause all kinds of confusion. Yes, it needs the quotes around it.

Newbie Joined: 17 Oct 2008 Posts: 7 Location: WV

Well Vij, that last modification to Fang's script seems to do the trick! =D Thanks fellas! All of ya. Beautiful!

Sorcerer Joined: 13 Jan 2006 Posts: 715

Ah, it was the quotes I was missing. I didn't know they were needed inside of %subchar too

Otherwise I had already made that other change to the script. I just couldn't get it to capture properly. Which I now know is because of the commans.

Thanks again Vij and Fang