Zugg Software :: View topic

Wanderer Joined: 30 Jun 2007 Posts: 53

Hey, no problem :)

I am actualy having a problem with the abouce trigger, it works fine until it makes me avoid a rough guard and then it just seems to want to ignore all the NPC's I want to kill. Any ideas?

Wanderer Joined: 30 Jun 2007 Posts: 53

Wait, I figred it out :) Something REALLY obvious!

I had forgtten to remove the guard from the moblist and because I had the moblist reset after I kill somthing it would never fire off.

Eul.

Wanderer Joined: 30 Jun 2007 Posts: 53

Kill stealing, nobody likes it so I don’t really want my script to do it.

The way I figured I would get around this is by making another variable called playerlist, and here is the code I have for it so far:

Magician Joined: 28 Jan 2007 Posts: 430

Yup.

Creating a generic string list from a big list such as you're trying to do is always a pretty tricky business. I'd really need to know the *exact* output your mud has for the "Heroes online" line until I could help any further, though.

Right now, supposing that "*" would do the job, correct syntax would be

Wanderer Joined: 30 Jun 2007 Posts: 53

Yes, I understand. You create a list of the players with "who online", then while the script is running it will check to see if anyone on the screen you are standing on is one of those players and add there name to a new list. Then I add a line of code into my killing trigger to check to see if the playerlistcurrent has anything in it, if it dose it will asume that that player has "claimed" the NPC's on the screen and move insted of starting combat.

Thanks, I'll post here when I have had time to go through it all, make it work, and more importantly understand why it works :)

Eul

Posted: Mon Jul 09, 2007 1:29 pm

Prog is right about the #additem syntax. When you're using %additem, though, you must use the format "#var something %additem(newitem,@something)" or the list won't get updated. %additem returns an updated list, it doesn't affect the variable itself. Calling a function on its own like that is bad practice anyway - use the #call command, so

#trig {something} {%function(whatever)}
becomes
#trig {something} {#call %function(whatever)}

Also, when you want to refer to the contents of a wildcard later, you must surround it with brackets.

Heroes:*

as the pattern won't do what you want, but

Heroes:(*)

will. Furthermore, when you later refer to the wildcard in the script, you use one of the %1-%99 variables like in prog's example. Wildcards are numbered from left to right by the position of their opening bracket:

#trig {this is (%w), it has (%d) days left} {}

If you want to reference the contents of the %w wildcard, you substitute %1 in the script. If you want to reference the %d wildcard, you use %2 and so on.

As for your heroes online list, you'll have to use %replace or %subchar to replace the spaces in the list with pipe characters - | - in order to get the list to format properly. You must also use #forall to populate the list because if you did "#additem something bob|harry|sally|joe|fred" you'd end up with the string "bob|harry|sally|joe|fred" added as a single item in the @something list. The proper script will probably look something like this:

#trig {Heroes Online: (*)} {PlayerList="";#forall %replace(%1," ","|") {#additem PlayerList %i}}

With all this said, though, wouldn't it be much easier to detect if a player, any player, is in the room, and not to have to bother capturing all the names? How are players listed in the room description?

Magician Joined: 28 Jan 2007 Posts: 430

Wanderer Joined: 30 Jun 2007 Posts: 53

I had originally tried to see if there was a way to do this but sadly players show up just the same as NPC's do on a screen, they sometimes have extra titles but sometimes don’t. You could literally end up with:
A commoner is standing here.
Bob is standing here.

And while I am not to sure if it shows up any extra text if bob is fighting the commoner it is still bad etiquette to attack an NPC that already has another player in front of it, well, IMO anyway.

I guess I could try to set it up to not start combat if anything not listed in my original moblist "is standing here." I just figured this would be easier. Smile

Eul.

Posted: Mon Jul 09, 2007 2:00 pm

Well, that method would lead to you skipping some rooms that you could kill stuff in. The bot currently adds everything in the room to the list, right, regardless of whether it's a mob you want to kill or not? If that's the case, why not something like this:

#trig {(*) is here.} {#if (%ismember(%1,@playerlist)) {#var MobList %additem("PLAYER",@MobList)} {#var MobList %additem("%1",@MobList)}}

and then all you need to do is add another %ismember check with your rough guard check, seeing if PLAYER is a member of the list.

Wanderer Joined: 30 Jun 2007 Posts: 53

No, it currently dose not add everything to the moblist, just stuff from a predefined list. I am starting to get a little confused with all these different ideas. I am going to take a break before getting stuck back into this Smile

, although the above line looks like it would make more sense than my current set up.

Back later with results.

Eul

Wanderer Joined: 30 Jun 2007 Posts: 53

Ok, I have had another go at this. I couldent get my head around how to combine these to triggers so I dident bother, so they should both scan the npc list line and one will pull out NPC's and the other any players included in the playerlist.

Posted: Tue Jul 10, 2007 2:18 pm

Your trigger for players is "a(*) standing here." - but from what you've previously said, the text for players in the room is like "Bob is standing here." - there's no "a" at the start and, furthermore, you'll capture the "is" part into the wildcard, which will prevent the %ismember(%1,@playerlist) from matching. Try this pattern instead:

(%w) is standing here.

Also, %ismember is case sensitive, so you must check for PLAYER and not Player in your walk trigger.

Wanderer Joined: 30 Jun 2007 Posts: 53

Yes, you are right. Although my above was an example, as I was not at my computer to give a piece of exact output from the mud. It actualy lists all of the NPC's and players in one line. So ignoring the little errors above (I'll change it in a seccond) I am trying to get the script to capture everything in the last line(s) of text from the mud and examine it to see if it contains a player name. Would I have to change the trigger to something like this;

#TRIGGER {(*) standing here.} {#if (%ismember(%1,@playerlist)) {#var MobList %additem("PLAYER",@MobList)} {#DELITEM moblist PLAYER}

Or is this being too vuage for the program?

One last think, I have come across a new NPC that has a new pose in a room. There is two children on a screen and they appear on the NPC line as "Two children are chasing each other here."

How can I sprerate my #TRIGGER {a(*) ({dog|cat|rat|commoner|guard})* standing here.} to have this extra field?

Posted: Tue Jul 10, 2007 2:49 pm

The "a(*) ({dog|cat|rat|commoner|guard})* standing here." solution is simple providing that it doesn't cause any false positives - "a(*) ({dog|cat|rat|commoner|guard|children})* here." - assuming that they're actually one mob and the keyword is children, anyway.

As for the playerlist trigger, you really MUST use "(%w) is standing here." Given the line "Bob is standing here", the value of %1 will be "Bob is". "Bob is" will NOT be a member of @playerlist even if "Bob" is a member. You need to match on the name and only the name. I'd also advise against deleting the PLAYER item from the list if the item isn't in the playerlist, because this trigger is generic enough that it's going to fire on other things, like mobs in the room. Just because one specific thing in the room isn't a player doesn't mean that there are NO players in the room.

Wanderer Joined: 30 Jun 2007 Posts: 53

Ok, two more questions :)
Is there a way of changing the string to look like this;

Posted: Tue Jul 10, 2007 3:44 pm

In answer to your first question - yes, just like that. But bear in mind that "chasing here" won't match "chasing each other here".

You can probably do what you want with the other one by making it

a(*) ({dog|cat|rat|commoner|guard|@playerlist})* standing here.

but this will work in exactly the same way as the

a(*) standing here.

trigger you had before. So in short, no, you can't use that.

Wanderer Joined: 30 Jun 2007 Posts: 53

I have a problem with the below trigger;

Magician Joined: 28 Jan 2007 Posts: 430

uh,

I understand what you're trying to do but I'm pretty sure #forall isn't the way to obtain it.

#forall is

list=sword|dagger|mace

#forall @list {repair %i}

For the thing you're trying to do, I'd suggest the following.

Wanderer Joined: 30 Jun 2007 Posts: 53

Yes it made sense, but I was using match because I didn’t want to make another list. What I currently have is a trigger that picks everything in the room and ands it to inroom so if there was a commoner there it would add the following;
a|commoner|is|staanding|here

The kill trigger matches key words with @npclist and @playerlist and if it finds a match it will start combat, or #step. If I was to use the revised method I would also have to rewrite how my scrip captures npc's in a room, and I only just finished that :)

Thanks for the feed back though, I will be rewriting this later today, but if you could possibly help make this work with the way my inroom list is generated that would be great :)

Thanks,

EDIT:

I have changed it a little, but it is still not working.

#TRIGGER {^There are* obvious exits*} {#alarm {+1} {#forall @inroom {#if (%match("guard",%i) or %match({@playerlist},%i)) {#step;#pause;#abort 1} {#if (%match({@npclist},%i)) {#PAUSE;#ALARM {+1} {#additem combat %i;k %i;#abort 1} {#step;#pause;#abort 1}}}}}}}

It says there is a error where the red # is, but I am not sure what it is.

Eul.

Wizard Joined: 11 Jul 2002 Posts: 1265 Location: USA

I used quotes because the code tags do not allow you to color your text.

There were two errors. First the } was in the wrong spot.
And the } was an extra.

Wanderer Joined: 30 Jun 2007 Posts: 53

Ok, I changed it again:

Wizard Joined: 11 Jul 2002 Posts: 1265 Location: USA

Yes

Note that I did not fix your script as I have not been reading this thread. I simply fixed a script error. There could be a way to make it work properly by moving the } around.

Wanderer Joined: 30 Jun 2007 Posts: 53

Ok, I tried moving the {} but to no avail, I had it working like this;

Magician Joined: 28 Jan 2007 Posts: 430

I'm sorry for humming the same tune but using several string lists and different setup would cause less trouble and also be easier to understand for starters.

Wanderer Joined: 30 Jun 2007 Posts: 53

The only reason why I dident want to use this method was because I had just rewritten the way the script picks up npcs in the room, I mentioned that before (scrool up if you want to see how it dose it now Smile

). Sorry but I though the new method was better because it was adding everything in the room into a list rather than just picking up stuff that matches the trigger bellow. I guess it is to complicated so I'll just try and take a step back and get this to work the sugested way.

Not waste my time Question

Thanks for taking the time to nudge me in the right direction again!

Eul.