Zugg Software :: View topic

Newbie Joined: 03 Oct 2008 Posts: 4

I was using Rahabs old package i believe written for CMUD 2.x for quite awhile with CMUD 3.13a. I just upgraded to 3.33a. I reinstalled his package that now has 3.2 as the version number, however it is not working correctly:

- the command imp and imp help work fine
- the command impoption announce long, or any impoption announce commands - just keeps saying "Imp announced turned off" all the time.
- an incorrect impoption announce, such as impoption announce xxx - seems to work, it says unknown mode.
- impoption all works as intended.
- skill spell casting 1209 turns up as 0 - it should set it to 1209
- show skills, which should change my skills to abbreviated versions and show the actual skill number, doesnt process at all it just shows the regular mud output.

Any idea what may be the issue? I had a heck of a time even getting the package to work, the old one wouldnt delete even when it said it did, it wouldnt install, lots of access violations as usual... Is CMUD code supposed to be backwards compatible or does everything just seem to break after every update? Any insight would be appeciated. If i can roll back to 3.2 where this package is supposed to be working i would, actually i would just roll back to the laggy 3.13 if i could at this point.

Thanks!
Ziplok

Newbie Joined: 03 Oct 2008 Posts: 4

Another note, as soon as i once do the command "impoption anncoune long", some variables appear in the package editor under the window datmud for some reason:

//SaveState/Dartmud/ImpStates string literal
//SaveState/Dartmud/ImpStates database record
//SaveState/Dartmud/ImpStates database record

What the heck is going on with this program?

Wizard Joined: 22 Mar 2007 Posts: 2320

I'm afraid I haven't updated that package in a very long time. Version 3.2 is the version number of the package itself, not the version of Cmud that it works with. It was never updated to work with version 3.xx.

Creating those variables under the dartmud window is perfectly normal, as I recall, because the impoption command sets certain defaults which have to be stored in variables.

There are quite a few things that I would change if I were to rewrite it for version 3.33. Several new features of 3.xx would improve the package quite a bit. And yes, the change from version 2.xx to version 3.xx does require a few changes. I recall I did a few odd things because of limitations that existed under 1.xx and early versions of 2.xx.

If I have time, I might take a look at the package and see what might be a problem under version 3.xx. But frankly, I haven't actually played Dartmud in a couple years. I may have some time this week to take a look at it (I have some time off), but no promises. I'm sorry that it isn't working under 3.xx--I was quite proud of that package!

Newbie Joined: 03 Oct 2008 Posts: 4

Thank you Rahab, that package is completely awesome!

I got more of the package working, apparently when the package installs now, it does create a SaveState module under the Dartmud window, however the module is empty when created, it doesnt create the Dartmud class inside it that holds the ImpStates, SkillNames, and Skills database records. This seems to be what was causing the standalone variables called "//SaveState/Dartmud/ImpStates" and such..

I fixed that by pulling the old SaveState from the 2.x package and replacing the empty one, it worked fine and settings commands such as impoption announce long are all now working.

-----

The only issue left that I can see is a little tough to describe. Here is an example of it:

* You think your blur skill has improved. *
10--blur skill (A Novice: 155 to roll)
ooc blur +
You think you would have succeeded.
You say (OOC), 'blur +'
show skills *blur*
blur raised to minimum for A Tyro
blur 585 Mas Skill does not match level

- The blur skill is 10, which would be "A Novice", however its saying it needs 155 to roll now.
- The imp announce works fine.
- Now when I show skills again, it detects that the skill is really A Tyro, thats fine.
- However it now sets the skill to be 585 instead of what Tyro should be.
- The shortened level description of Mas does properly display for what a 585 skill would be(Master)!

Also, a few skill levels seem to work just fine, Virtuoso, Very Good..

Another example:

From the package: language#common 740 Sup
What the mud sent: language#common: Average.

No errors or corrections or anything for the 2nd example. What kind of issue could this possibly be? Parsing? Corruption? The list of skill levels in the code looks correct still:

<var name="levelValues" id="14">
<value>Not Very Good=50|Adroit=285|A Novice=10|An Expert=450|Proficient=200|Average=90|Legendary=1700|Consummate=1050|An Adept=740|A Virtuoso=1200|A Tyro=4|Superb=515|Fair=165|Excellent=390|Above Average=110|A Master=585|Below Average=70|A Grandmaster=1400|Poor=30|Renowned=825|Good=240|Unskilled=1|A Beginner=18|A High Master=920|Very Good=335|Eminent=660|Able=135</value>
<notes>The key is the full name of a level, the value is the minimum skill number within the range of that level</notes>
</var>

Newbie Joined: 03 Oct 2008 Posts: 4

Seems like it may have something to do with the function called LevelName:

#local $key
$key = %iskey( @LevelValues, $input)
#if ($key) {#return %item( %dbkeys( @levelValues), $key)}
#return @abbrevLevels.$input

When i echo $input as it comes into the function it is showing as: A Tyro
When $key is set by %iskey, it comes up as: 16 (which seems to me from the levelValues below to be: A Master

I would think it should be returning 11 instead of 16?

Wizard Joined: 22 Mar 2007 Posts: 2320

Hm. Thanks for narrowing that down for me. I'll see what I can do.