Zugg Software :: View topic

Posted: Fri Nov 23, 2007 4:20 am

#VAR currentBox {simple copper box}

#TR {After careful inspection, you fail to see any traps on your @currentBox.}

Then use this in the test pattern tab of the trigger:

After careful inspection, you fail to see any traps on your simple copper box.

Even if i enclose the variable in {} it still fails.

Posted: Fri Nov 23, 2007 6:57 am

This works for me. I tested with a #SHOW line in a blank session.

Posted: Fri Nov 23, 2007 9:35 pm

Odd, cause i get this message on the compiled tab of the trigger:

Error compiling script:
illegal property: $

Aha, now i see why, using the $ to force matching the end of line makes this trigger fail, without it, it works.

Posted: Mon Nov 26, 2007 4:55 pm

Please show us the *exact* pattern that is failing. Your example above didn't have any $ character in it. Or, go to the XML tab and paste the XML code here (using a [code] tag)

Posted: Mon Nov 26, 2007 7:51 pm

it was

#TR {After careful inspection, you fail to see any traps on your @currentBox.$}

i had just somehow missed putting the $ in

Wizard Joined: 25 Mar 2003 Posts: 1113 Location: USA

I've seen similar problems with my score triggers, where I use @char to represent a person's name (since %char didn't seem to work in CMUD trigger patterns). I have three score triggers, all for different versions of the score display; one worked fine, one didn't match any lines, and one matched the first 10 states out of 12 and then gave up (weird). I replaced the @char with my actual character name and the triggers suddenly began working as I intended.

Posted: Tue Nov 27, 2007 1:42 am

One thing to check is to always make sure there isn't a space after the $ in the pattern field. This seems to happen easily, and since the space can't be seen, it's hard to spot unless you put the cursor at the end of the pattern. If there is a space after it, then the $ becomes the newline character for a multiline trigger, instead of matching the end of the line.

I'm actually considering trimming any spaces from the end of the pattern and forcing people to use %s for trailing spaces to prevent this kind of problem.

Posted: Tue Nov 27, 2007 2:09 am

Can you not have it default to using a %q instead?

The reason the $ was on there in the is from my hitting that little spot right in front of the line that will highlight the whole line in the scrollback buffer.

That technique inserts the $ automatically.

Back on topic, I just double checked to be sure, and there are no trailing spaces being sent by the mud.

And another test shows that technique would grab them anyway and place the $ appropriately.

Posted: Tue Nov 27, 2007 2:51 am

Shalimar, I think Zugg meant to check for spaces at the end of your pattern in the trigger, after the $ sign, not in the text you receive from the MUD.

Posted: Tue Nov 27, 2007 3:59 am

I did that too, no trailing spaces.

Posted: Tue Nov 27, 2007 6:02 am

I figured out what happened and it's really simple. The '.' is causing a parsing bug. If you quote it using

Wizard Joined: 25 Mar 2003 Posts: 1113 Location: USA

Oooo. Good find, Tech! Thanks!

Posted: Tue Nov 27, 2007 9:03 pm

Thanks for finding this Tech! That helps me a lot! You are exactly right. It is still a bug because there isn't a valid key reference after it, so I should be able to fix that.

Posted: Tue Nov 27, 2007 11:40 pm

BTW, it's actually pretty easy to see this problem if you go into the settings editor, select the trigger, and click the Compiled Pattern tab. It will show the error: "illegal property: $". If a trigger pattern doesn't compile, then it might have problems working.

Just a reminder that those "Compiled..." tabs can be useful in helping to track down bugs and to report problems. This would have also shown up in the compatibility report. So be sure to use those tools when you are having trouble with scripts.